Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth2wrap: update interfaces #2709

Merged
merged 7 commits into from
Nov 20, 2023
Merged

eth2wrap: update interfaces #2709

merged 7 commits into from
Nov 20, 2023

Conversation

xenowits
Copy link
Contributor

Update eth2client interfaces to reflect go-eth2-client's changes in their new release v0.19.5.

category: feature
ticket: #2708

@xenowits xenowits self-assigned this Nov 13, 2023
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 102 lines in your changes are missing coverage. Please review.

Comparison is base (4769b50) 53.45% compared to head (d8a6008) 53.45%.
Report is 2 commits behind head on main.

❗ Current head d8a6008 differs from pull request most recent head d111324. Consider uploading reports for the commit d111324 to get more accurate results

Files Patch % Lines
app/eth2wrap/eth2wrap_gen.go 23.07% 40 Missing ⚠️
app/app.go 25.00% 10 Missing and 2 partials ⚠️
app/vmock.go 0.00% 9 Missing ⚠️
core/bcast/bcast.go 43.75% 6 Missing and 3 partials ⚠️
core/validatorapi/validatorapi.go 36.36% 5 Missing and 2 partials ⚠️
core/deadline.go 0.00% 5 Missing ⚠️
core/gater.go 37.50% 3 Missing and 2 partials ⚠️
core/scheduler/scheduler.go 50.00% 3 Missing and 2 partials ⚠️
core/tracker/inclusion.go 40.00% 2 Missing and 1 partial ⚠️
testutil/beaconmock/headproducer.go 40.00% 2 Missing and 1 partial ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2709      +/-   ##
==========================================
- Coverage   53.45%   53.45%   -0.01%     
==========================================
  Files         201      201              
  Lines       27614    27634      +20     
==========================================
+ Hits        14762    14772      +10     
+ Misses      11037    11036       -1     
- Partials     1815     1826      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

app/app.go Show resolved Hide resolved
app/eth2wrap/eth2wrap_test.go Show resolved Hide resolved
@dB2510 dB2510 added the merge when ready Indicates bulldozer bot may merge when all checks pass label Nov 20, 2023
Copy link

sonarcloud bot commented Nov 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
5.3% 5.3% Duplication

@obol-bulldozer obol-bulldozer bot merged commit 7312ea7 into main Nov 20, 2023
13 checks passed
@obol-bulldozer obol-bulldozer bot deleted the xenowits/new-updates branch November 20, 2023 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants