-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
app: add teku simnet integration test #271
Conversation
Codecov Report
@@ Coverage Diff @@
## main #271 +/- ##
==========================================
- Coverage 58.50% 58.10% -0.41%
==========================================
Files 53 53
Lines 3974 4000 +26
==========================================
- Hits 2325 2324 -1
- Misses 1329 1350 +21
- Partials 320 326 +6
Continue to review full report at Codecov.
|
0e2eb7c
to
824f565
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
func TestSimnetNoNetwork(t *testing.T) { | ||
ctx, cancel := context.WithCancel(context.Background()) | ||
defer cancel() | ||
//go:generate go test . -run=TestSimnetNoNetwork_TekuVC -integration -v |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we name run flag as -run=test_teku_simnet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm adding another test for lighthouse as well, so not sure two flags are required
@@ -62,6 +63,9 @@ type staticOverride struct { | |||
|
|||
// newHTTPServer returns a beacon API mock http server. | |||
func newHTTPServer(addr string, overrides ...staticOverride) (*http.Server, error) { | |||
debug := os.Getenv("BEACONMOCK_DEBUG") == "true" // NOTE: These logs are verbose, so disabled by default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why we have introduced this ENV variable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is test code, I wanted the option to be able to debug httpserver stuff with this logging, but it is very verbose... not sure how else.
Default to gnosis as preset base. This provides shorter slots_per_epoch for lighthouse in simnet. Default to 1s slot duration. See sigp/lighthouse#3033 for reference. category: test ticket: #271
Adds an simnet integration test that uses teku as validator client.
category: test
ticket: #268