app/log: on-disk log writing #2713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Write debug logs on disk if `--log-output-path` is specified. Log files are rotated automatically once the file size reaches 50MB. Rotated log files will be kept for 7 days - max 10 rotated files will be kept, whatever comes first.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2713 +/- ##
==========================================
- Coverage 53.36% 53.23% -0.13%
==========================================
Files 199 199
Lines 27397 27428 +31
==========================================
- Hits 14621 14602 -19
- Misses 10969 11014 +45
- Partials 1807 1812 +5 ☔ View full report in Codecov by Sentry. |
dB2510
approved these changes
Nov 20, 2023
app/log/config.go
Outdated
| Logger: &lumberjack.Logger{ | ||
| Filename: u.Path, | ||
|
|
||
| MaxBackups: 10, |
There was a problem hiding this comment.
nit: add a const for MaxBackups field and a godoc for that const
|
Kudos, SonarCloud Quality Gate passed!
|
gsora
added
the
merge when ready
xenowits
pushed a commit
that referenced
this pull request
Dec 12, 2023
Write debug logs on disk if `--log-output-path` is specified. Log files are rotated automatically once the file size reaches 50MB. Rotated log files will be kept for 7 days - max 10 rotated files will be kept, whatever comes first. category: feature ticket: #2671
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Write debug logs on disk if
--log-output-pathis specified.Log files are rotated automatically once the file size reaches 50MB.
Rotated log files will be kept for 7 days - max 10 rotated files will be kept, whatever comes first.
category: feature
ticket: #2671