Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: remove leadercast consensus #2719

Merged
merged 1 commit into from
Nov 20, 2023
Merged

core: remove leadercast consensus #2719

merged 1 commit into from
Nov 20, 2023

Conversation

dB2510
Copy link
Contributor

@dB2510 dB2510 commented Nov 20, 2023

Removes leadercast consensus and makes QBFT the default one.

category: refactor
ticket: #2505

Copy link

sonarcloud bot commented Nov 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (2473860) 53.57% compared to head (1550161) 53.34%.
Report is 2 commits behind head on main.

Files Patch % Lines
app/app.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2719      +/-   ##
==========================================
- Coverage   53.57%   53.34%   -0.23%     
==========================================
  Files         201      199       -2     
  Lines       27614    27397     -217     
==========================================
- Hits        14794    14616     -178     
+ Misses      11007    10970      -37     
+ Partials     1813     1811       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dB2510 dB2510 linked an issue Nov 20, 2023 that may be closed by this pull request
@dB2510 dB2510 requested a review from gsora November 20, 2023 12:05
@dB2510 dB2510 self-assigned this Nov 20, 2023
@dB2510 dB2510 added the merge when ready Indicates bulldozer bot may merge when all checks pass label Nov 20, 2023
@obol-bulldozer obol-bulldozer bot merged commit d6f68fb into main Nov 20, 2023
15 checks passed
@obol-bulldozer obol-bulldozer bot deleted the dhruv/rmleadercast branch November 20, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove leadercast
2 participants