featureset: remove stable feature flags #2735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
3 tasks
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2735 +/- ##
==========================================
+ Coverage 53.29% 53.31% +0.02%
==========================================
Files 199 199
Lines 27489 27486 -3
==========================================
+ Hits 14649 14653 +4
+ Misses 11024 11020 -4
+ Partials 1816 1813 -3 ☔ View full report in Codecov by Sentry. |
xenowits
reviewed
Dec 1, 2023
| // QBFTConsensus introduces qbft consensus, see https://github.com/ObolNetwork/charon/issues/445. | ||
| QBFTConsensus Feature = "qbft_consensus" | ||
| // Priority enables the infosync component using the priority protocol. | ||
| Priority Feature = "priority" | ||
| // MockAlpha is a mock feature in alpha status for testing. | ||
| MockAlpha Feature = "mock_alpha" |
There was a problem hiding this comment.
nit: can also remove mockalpha if not required
not sure where it is used
There was a problem hiding this comment.
As mentioned in its godoc, it is a mock feature in alpha status for testing.
xenowits
approved these changes
Dec 1, 2023
gsora
approved these changes
Dec 4, 2023
dB2510
added
the
merge when ready
xenowits
pushed a commit
that referenced
this pull request
Dec 12, 2023
Removes feature flags from feature set with stable status. category: misc ticket: #2720
gsora
pushed a commit
that referenced
this pull request
Dec 21, 2023
Removes feature flags from feature set with stable status. category: misc ticket: #2720
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes feature flags from feature set with stable status.
category: misc
ticket: #2720