Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: removed leadercast leftovers #2782

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Conversation

pinebit
Copy link
Contributor

@pinebit pinebit commented Jan 12, 2024

After removing the leadercast component, some leftovers were remaining the code, hence the cleanup.

category: misc
ticket: none

Copy link

sonarcloud bot commented Jan 12, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@pinebit pinebit changed the title Removed leadercast leftovers core: removed leadercast leftovers Jan 12, 2024
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (347a7d1) 53.17% compared to head (8263c85) 53.28%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2782      +/-   ##
==========================================
+ Coverage   53.17%   53.28%   +0.10%     
==========================================
  Files         199      199              
  Lines       27604    27603       -1     
==========================================
+ Hits        14678    14707      +29     
+ Misses      11104    11071      -33     
- Partials     1822     1825       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pinebit pinebit added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jan 12, 2024
@obol-bulldozer obol-bulldozer bot merged commit 28a96eb into main Jan 12, 2024
15 of 16 checks passed
@obol-bulldozer obol-bulldozer bot deleted the pinebit/leadercast-leftovers branch January 12, 2024 11:46
@gsora gsora added the v0.19.1 label Jan 15, 2024
@gsora gsora added the qs-audit label Jan 22, 2024
gsora pushed a commit that referenced this pull request Jan 24, 2024
After removing the leadercast component, some leftovers were remaining the code, hence the cleanup.

category: misc
ticket: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass qs-audit v0.19.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants