dkg/bcast: exchange full messages #2798
Conversation
Instead of passing around hashes, share the whole message with the target for them to validate.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2798 +/- ##
=========================================
+ Coverage 0 53.28% +53.28%
=========================================
Files 0 199 +199
Lines 0 27669 +27669
=========================================
+ Hits 0 14744 +14744
- Misses 0 11096 +11096
- Partials 0 1829 +1829 ☔ View full report in Codecov by Sentry. |
|
|
||
| target := targetFn(messageID) | ||
|
|
||
| err := msgAny.UnmarshalTo(target) |
There was a problem hiding this comment.
this is still an incomplete solution as a malicious peer can still broadcast a malformed message in the correct pb.FrostRount1Casts. They can still be able to get the sign on this data from other peers.
There was a problem hiding this comment.
They don't control the input anymore though, i.e. it's not just a slice of bytes.
What do you suggest we check?
There was a problem hiding this comment.
not sure if we can check each field in pb.FrostRound1Cast
gsora
added
the
merge when ready
|
Instead of passing around hashes, share the whole message with the target for them to validate. category: refactor ticket: none
Instead of passing around hashes, share the whole message with the target for them to validate.
category: refactor
ticket: none