Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gomod: update Herumi BLS to v1.33.0 #2814

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Conversation

gsora
Copy link
Collaborator

@gsora gsora commented Jan 23, 2024

In order to support the latest version of the Herumi BLS library Charon links against, we had to update our Docker container to build and run on Debian Bookworm.

category: fixbuild
ticket: none

Closes #2814.

In order to support the latest version of the Herumi BLS library Charon
links against, we had to update our Docker container to build and run on
Debian Bookworm.
Copy link

sonarcloud bot commented Jan 23, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (254a0a3) 53.28% compared to head (0d8052f) 53.33%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2814      +/-   ##
==========================================
+ Coverage   53.28%   53.33%   +0.04%     
==========================================
  Files         199      199              
  Lines       27696    27700       +4     
==========================================
+ Hits        14759    14773      +14     
+ Misses      11108    11098      -10     
  Partials     1829     1829              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gsora gsora changed the title go.mod: update Herumi BLS to v1.33.0 gomod: update Herumi BLS to v1.33.0 Jan 23, 2024
Copy link
Contributor

@dB2510 dB2510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious what is the change in image size because of this change?

@gsora
Copy link
Collaborator Author

gsora commented Jan 23, 2024

It's about 86mb bigger.

@gsora gsora added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jan 23, 2024
@obol-bulldozer obol-bulldozer bot merged commit 4d66a10 into main Jan 23, 2024
17 of 18 checks passed
@obol-bulldozer obol-bulldozer bot deleted the gsora/update-herumi-bls branch January 23, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants