testutil: fixed promrated.go #2815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2815 +/- ##
==========================================
- Coverage 53.30% 53.25% -0.06%
==========================================
Files 199 199
Lines 27700 27705 +5
==========================================
- Hits 14765 14753 -12
- Misses 11103 11125 +22
+ Partials 1832 1827 -5 ☔ View full report in Codecov by Sentry. |
gsora
approved these changes
Jan 23, 2024
dB2510
reviewed
Jan 23, 2024
cmd/cmd.go
Outdated
| // passwords in valid URLs provided in ".*address.*" flags and redacting auth tokens. | ||
| func redact(flag, val string) string { | ||
| func Redact(flag, val string) string { |
There was a problem hiding this comment.
nit: can just copy this function to testutil/promrated/promrated.go as this not a "big" function rather than importing whole cmd package to promrated. We don't use anything else from cmd package, right?
There was a problem hiding this comment.
Agreed, copied with slight modification.
|
xenowits
approved these changes
Jan 24, 2024
pinebit
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing promrated.go (resolving TODOs).
category: misc
ticket: none