cmd: fix create cluster bug

[gsora]

Cherrypick of 2852 on main-v0.19.

--

Fix bug in create cluster command.

--

From @xenowits's explanation on slack:

When create cluster command is run twice in the same directory, it doesn’t error out with “Fatal error: existing node directory found, please delete it before running this command” while it should

Explanation: When we provide a definition file to the create cluster command, we don’t set the "conf.NumNodes" field when verifying the config

//.....
func validateCreateConfig(ctx context.Context, conf clusterConfig) error {
    if conf.NumNodes == 0 && conf.DefFile == "" { // if there's a definition file, infer this value from it later
       return errors.New("missing --nodes flag")
    }

    // Check for valid network configuration.
    if err := validateNetworkConfig(conf); err != nil {
       return errors.Wrap(err, "get network config")
    }

    // BUG: conf.NumNodes is zero here!!
    if err := detectNodeDirs(conf.ClusterDir, conf.NumNodes); err != nil {
       return err
    }

category: bug
ticket: #2851

[sonarcloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8483677) 53.25% compared to head (67f576a) 53.23%.

Additional details and impacted files

@@              Coverage Diff               @@
##           main-v0.19    #2854      +/-   ##
==============================================
- Coverage       53.25%   53.23%   -0.03%     
==============================================
  Files             200      200              
  Lines           27697    27700       +3     
==============================================
- Hits            14750    14745       -5     
- Misses          11120    11126       +6     
- Partials         1827     1829       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.