cluster: handle definition download error #2898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle non-200 HTTP status code in a graceful way, returning it instead of potentially unmarshalling-related errors.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2898 +/- ##
==========================================
- Coverage 53.62% 53.59% -0.04%
==========================================
Files 200 200
Lines 28212 28215 +3
==========================================
- Hits 15129 15121 -8
- Misses 11215 11222 +7
- Partials 1868 1872 +4 ☔ View full report in Codecov by Sentry. |
dB2510
approved these changes
Feb 23, 2024
gsora
added
the
merge when ready
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle non-200 HTTP status code in a graceful way, returning it instead of potentially unmarshalling-related errors.
category: bug
ticket: #2897
Closes #2897.