Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: add jaeger service name flag #303

Merged
merged 1 commit into from
Mar 30, 2022
Merged

cmd: add jaeger service name flag #303

merged 1 commit into from
Mar 30, 2022

Conversation

corverroos
Copy link
Contributor

@corverroos corverroos commented Mar 29, 2022

Adds a --jaeger-service flag to override jager service name in simnet. Also add support for deterministic duty rooted spans.

category: feature
ticket: #302

@codecov
Copy link

codecov bot commented Mar 29, 2022

Codecov Report

Merging #303 (148575e) into main (1de96c5) will increase coverage by 0.04%.
The diff coverage is 43.24%.

@@            Coverage Diff             @@
##             main     #303      +/-   ##
==========================================
+ Coverage   55.95%   56.00%   +0.04%     
==========================================
  Files          57       57              
  Lines        4459     4491      +32     
==========================================
+ Hits         2495     2515      +20     
- Misses       1625     1637      +12     
  Partials      339      339              
Impacted Files Coverage Δ
app/tracer/trace.go 47.14% <15.78%> (-12.86%) ⬇️
core/types.go 40.00% <61.53%> (+18.94%) ⬆️
app/app.go 62.33% <100.00%> (+0.38%) ⬆️
cmd/run.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1de96c5...148575e. Read the comment docs.

Copy link
Contributor

@dB2510 dB2510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@corverroos corverroos merged commit 9f55f16 into main Mar 30, 2022
@corverroos corverroos deleted the corver/jaeger branch March 30, 2022 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants