Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: add tracing for all components #304

Merged
merged 3 commits into from
Mar 30, 2022
Merged

core: add tracing for all components #304

merged 3 commits into from
Mar 30, 2022

Conversation

corverroos
Copy link
Contributor

@corverroos corverroos commented Mar 29, 2022

Add WireOptions and WithTracing that wraps all core workflow component input functions in tracing spans. Also trace all logs.

category: feature
ticket: #302

@codecov
Copy link

codecov bot commented Mar 29, 2022

Codecov Report

Merging #304 (6e87b40) into corver/jaeger (148575e) will decrease coverage by 1.11%.
The diff coverage is 24.37%.

❗ Current head 6e87b40 differs from pull request most recent head 02b32a0. Consider uploading reports for the commit 02b32a0 to get more accurate results

@@                Coverage Diff                @@
##           corver/jaeger     #304      +/-   ##
=================================================
- Coverage          56.00%   54.88%   -1.12%     
=================================================
  Files                 57       58       +1     
  Lines               4491     4624     +133     
=================================================
+ Hits                2515     2538      +23     
- Misses              1637     1747     +110     
  Partials             339      339              
Impacted Files Coverage Δ
core/interfaces.go 0.00% <0.00%> (ø)
core/types.go 32.25% <ø> (-7.75%) ⬇️
core/tracing.go 9.52% <9.52%> (ø)
core/validatorapi/validatorapi.go 42.85% <68.75%> (+1.00%) ⬆️
core/scheduler/scheduler.go 70.00% <80.00%> (+0.18%) ⬆️
app/app.go 62.58% <100.00%> (+0.24%) ⬆️
core/leadercast/leadercast.go 68.75% <100.00%> (+2.84%) ⬆️
core/parsigex/parsigex.go 61.97% <100.00%> (+2.27%) ⬆️
core/sigagg/sigagg.go 56.62% <100.00%> (+1.07%) ⬆️
core/validatorapi/router.go 63.36% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 148575e...02b32a0. Read the comment docs.

Copy link
Contributor

@dB2510 dB2510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great!

Base automatically changed from corver/jaeger to main March 30, 2022 07:13
@corverroos corverroos merged commit ff4c374 into main Mar 30, 2022
@corverroos corverroos deleted the corver/tracingcore branch March 30, 2022 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants