cmd: beacon node API timeouts #3164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3164 +/- ##
==========================================
+ Coverage 56.65% 56.68% +0.02%
==========================================
Files 208 208
Lines 29202 29216 +14
==========================================
+ Hits 16545 16561 +16
Misses 10828 10828
+ Partials 1829 1827 -2 ☔ View full report in Codecov by Sentry. |
Add two CLI flags for `run`: - `--beacon-node-timeout`, which allows users to specify a custom HTTP timeout used for beacon node API calls - `--beacon-node-submit-timeout`, that allows users to specify a custom HTTP timeout used for submission beacon node API calls, like block and attestation submission. Both flag default to the previous 2 seconds timeout.
gsora
force-pushed
the
gsora/custom-bn-timeouts
branch
from
3e8d7e0
to
b15f7dd
Compare
OisinKyne
reviewed
Jul 5, 2024
Co-authored-by: Oisín Kyne <4981644+OisinKyne@users.noreply.github.com>
|
OisinKyne
approved these changes
Jul 5, 2024
|
I'll wait for protocol team's review before merging. Thanks for your help on the CLI arguments copy! |
pinebit
approved these changes
Jul 8, 2024
gsora
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two CLI flags for
run:--beacon-node-timeout, which allows users to specify a custom HTTP timeout used for beacon node API calls--beacon-node-submit-timeout, that allows users to specify a custom HTTP timeout used for submission beacon node API calls, like block and attestation submission.Both flag default to the previous 2 seconds timeout.
category: feature
ticket: none