github/workflows: fix docker tags #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corverroos
commented
Apr 6, 2022
Comment on lines
-16
to
-20
| - id: get-version | ||
| run: | | ||
| version=$(echo "${{ github.sha }}" | cut -c1-8) | ||
| echo "::set-output name=version::$version" | ||
|
|
There was a problem hiding this comment.
no need for this, docker/metadata-action has support to configure tags
dB2510
reviewed
Apr 6, 2022
.github/workflows/build.yml
Outdated
| images: ghcr.io/obolnetwork/charon/charon | ||
| tags: | | ||
| # Tag "git short sha" on push to branch (main) | ||
| type=sha,event=branch,format=short |
There was a problem hiding this comment.
can ommit format since it is short by default short
.github/workflows/build.yml
Outdated
| type=sha,event=branch,format=short | ||
|
|
||
| # Tag "latest" on push to branch (main) | ||
| type=raw,event=branch,value=latest |
There was a problem hiding this comment.
we don't need this as line: 29 handle latest tag by default.
ref: https://github.com/docker/metadata-action#latest-tag
| push: true | ||
| build-args: GITHUB_SHA=${{ github.sha }} | ||
| tags: ${{ steps.meta.outputs.tags }} | ||
|
|
||
| - run: docker run ghcr.io/obolnetwork/charon/charon:${{steps.get-tag.outputs.tag}} charon run --help > cli-reference.txt |
There was a problem hiding this comment.
update this too since, there is no get-tag step.
| username: ${{ github.actor }} | ||
| password: ${{ secrets.CONTAINER_REGISTRY_SECRET }} | ||
|
|
||
| - uses: docker/build-push-action@v2 |
There was a problem hiding this comment.
we will not push at the time of release then?
There was a problem hiding this comment.
this PR adds tags: ['v*'] to build.yml which triggers it on release
corverroos
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes "build" github action to:
category: bug
ticket: #339