verifypr: update check and docs #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #447 +/- ##
==========================================
+ Coverage 54.87% 54.93% +0.05%
==========================================
Files 66 67 +1
Lines 6141 6164 +23
==========================================
+ Hits 3370 3386 +16
- Misses 2309 2315 +6
- Partials 462 463 +1
Continue to review full report at Codecov.
|
dB2510
approved these changes
Apr 27, 2022
| @@ -4,6 +4,7 @@ | |||
| - 2️⃣ PR body: Replace 'body...' with detailed description of the change. | |||
| - 3️⃣ category: pick one, delete the rest. | |||
| - 4️⃣ ticket: Replace #000 with link to a GitHub issue (or 'none' if PR is trivial). | |||
| - 5️⃣ feature_set: pick one (or delete completely if not applicable). | |||
There was a problem hiding this comment.
what are the cases of non-applicability?
maybe updating github actions would be one.
There was a problem hiding this comment.
Only category: feature requires feature_set I think
Co-authored-by: Dhruv Bodani <dhruvbodani2510@gmail.com>
corverroos
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
verifyprto validate feature_set tag, also update docs and PR template.category: misc
ticket: #381