core/qbft: refactor value to generic comparable

[corverroos]

Simplify and standardise qbft generic Value to built-in comparable.

This aligns the implementation with GoQuorum that uses hashes of the actual values in the algo. This makes the algo simpler and probably more performant. Actual values will need to "hidden" in the Msg implementation.

category: refactor
ticket: #445

[codecov]

Codecov Report

Merging #509 (cc966e8) into main (8fd44c2) will increase coverage by 0.86%.
The diff coverage is 77.63%.

❗ Current head cc966e8 differs from pull request most recent head a739003. Consider uploading reports for the commit a739003 to get more accurate results

@@            Coverage Diff             @@
##             main     #509      +/-   ##
==========================================
+ Coverage   56.28%   57.14%   +0.86%     
==========================================
  Files          87       87              
  Lines        8004     8021      +17     
==========================================
+ Hits         4505     4584      +79     
+ Misses       2898     2830      -68     
- Partials      601      607       +6     

Impacted Files	Coverage Δ
core/qbft/msgtype_string.go	40.00% <0.00%> (-10.00%)	⬇️
core/qbft/uponrule_string.go	40.00% <ø> (ø)
core/qbft/qbft.go	81.52% <78.66%> (+15.99%)	⬆️
app/app.go	63.31% <0.00%> (-0.89%)	⬇️
testutil/verifypr/verifypr.go	61.49% <0.00%> (+1.12%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db999b9...a739003. Read the comment docs.

[corverroos]

while in generate doesn't work