Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deposit: marshal array of deposits #557

Merged
merged 17 commits into from
May 19, 2022

Conversation

xenowits
Copy link
Contributor

@xenowits xenowits commented May 18, 2022

  • Add tests for testing MarshalDepositDatas.
  • The deposit data created by the likes of staking-deposit-cli consist of an array of deposit datas, one for each validator. For us, it means one for each DV.
  • It also contains an additional field, the deposit_cli_version.
  • Adds code to generate and test a deposit data file that can be used in og launchpad.
  • Modify createcluster to use the updated MarshalDepositData function.

category: feature
ticket: #554

@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #557 (32c5bfd) into main (5d482b5) will increase coverage by 0.19%.
The diff coverage is 86.84%.

@@            Coverage Diff             @@
##             main     #557      +/-   ##
==========================================
+ Coverage   54.99%   55.19%   +0.19%     
==========================================
  Files          91       91              
  Lines        8631     8622       -9     
==========================================
+ Hits         4747     4759      +12     
+ Misses       3247     3229      -18     
+ Partials      637      634       -3     
Impacted Files Coverage Δ
eth2util/deposit/deposit.go 58.55% <85.71%> (+8.97%) ⬆️
cmd/createcluster.go 55.49% <90.00%> (+0.92%) ⬆️
core/qbft/qbft.go 81.04% <0.00%> (-1.53%) ⬇️
app/app.go 66.27% <0.00%> (+2.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d482b5...32c5bfd. Read the comment docs.

@xenowits xenowits force-pushed the xenowits/marshal-array-of-deposits branch from 466d52a to b1e8201 Compare May 18, 2022 08:37
Base automatically changed from xenowits/output-deposit-data to main May 18, 2022 16:20
Copy link
Contributor

@dB2510 dB2510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xenowits xenowits added merge when ready Indicates bulldozer bot may merge when all checks pass labels May 19, 2022
@obol-bulldozer obol-bulldozer bot merged commit a223c6b into main May 19, 2022
@obol-bulldozer obol-bulldozer bot deleted the xenowits/marshal-array-of-deposits branch May 19, 2022 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants