-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deposit: marshal array of deposits #557
Conversation
Codecov Report
@@ Coverage Diff @@
## main #557 +/- ##
==========================================
+ Coverage 54.99% 55.19% +0.19%
==========================================
Files 91 91
Lines 8631 8622 -9
==========================================
+ Hits 4747 4759 +12
+ Misses 3247 3229 -18
+ Partials 637 634 -3
Continue to review full report at Codecov.
|
466d52a
to
b1e8201
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
MarshalDepositDatas
.staking-deposit-cli
consist of an array of deposit datas, one for each validator. For us, it means one for each DV.deposit_cli_version
.createcluster
to use the updatedMarshalDepositData
function.category: feature
ticket: #554