cmd: write lock file in create cluster #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #566 +/- ##
==========================================
- Coverage 54.47% 54.43% -0.05%
==========================================
Files 90 90
Lines 8512 8559 +47
==========================================
+ Hits 4637 4659 +22
- Misses 3242 3258 +16
- Partials 633 642 +9
Continue to review full report at Codecov.
|
leolara
approved these changes
May 19, 2022
corverroos
added
the
merge when ready
xenowits
reviewed
May 20, 2022
| "github.com/obolnetwork/charon/eth2util/deposit" | ||
| "github.com/obolnetwork/charon/eth2util/keystore" | ||
| "github.com/obolnetwork/charon/p2p" | ||
| "github.com/obolnetwork/charon/tbls" | ||
| "github.com/obolnetwork/charon/tbls/tblsconv" | ||
| ) | ||
|
|
||
| const clusterName = "local" |
There was a problem hiding this comment.
should put it together with other constants defaultWithdrawalAddr and defaultNetwork
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Write a cluster lock file when running charon create cluster.
Rename cluster_lock.json to cluster-lock.json as per suggestion from Oisin.
category: feature
ticket: #528