testutil/compose: implement v0 define command #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #569 +/- ##
==========================================
+ Coverage 54.42% 54.48% +0.05%
==========================================
Files 90 92 +2
Lines 8577 8634 +57
==========================================
+ Hits 4668 4704 +36
- Misses 3267 3283 +16
- Partials 642 647 +5
Continue to review full report at Codecov.
|
leolara
approved these changes
May 20, 2022
xenowits
approved these changes
May 20, 2022
| type vcType string | ||
|
|
||
| const ( | ||
| vcMock vcType = "mock" |
There was a problem hiding this comment.
nit: can remove vc prefix since it's already part of the type
Suggested change
| vcMock vcType = "mock" | |
| mock vcType = "mock" |
There was a problem hiding this comment.
I prefer to use common prefixes for enum
| func newDefineCmd() *cobra.Command { | ||
| cmd := &cobra.Command{ | ||
| Use: "define", | ||
| Short: "Define a cluster; including both keygen and running definitions", |
There was a problem hiding this comment.
nit:
Suggested change
| Short: "Define a cluster; including both keygen and running definitions", | |
| Short: "Define a cluster, including both generating keys and running definitions", |
There was a problem hiding this comment.
It is keygen definition, not actual key generation
corverroos
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the first iteration of the
compose definecommand. It just uses default configuration for now and outputs thecompose.ymlfile. Adding webui can be done later.category: feature
ticket: #568