Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace underscores with dashes #594

Merged
merged 1 commit into from
May 23, 2022

Conversation

xenowits
Copy link
Contributor

  • Replaces cluster_lock.json and cluster_definition.json with cluster-lock.json and cluster-definition.json respectively.
  • Change output text of charon create cluster to indicate that cluster-lock.json files are generated instead of manifest.json.

category: refactor
ticket: #588

@xenowits xenowits changed the title replace underscores with dashes refactor: replace underscores with dashes May 23, 2022
@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #594 (2c70498) into main (7eea302) will increase coverage by 0.46%.
The diff coverage is 20.00%.

@@            Coverage Diff             @@
##             main     #594      +/-   ##
==========================================
+ Coverage   54.21%   54.67%   +0.46%     
==========================================
  Files          95       95              
  Lines        8922     8921       -1     
==========================================
+ Hits         4837     4878      +41     
+ Misses       3386     3342      -44     
- Partials      699      701       +2     
Impacted Files Coverage Δ
cmd/createdkg.go 0.00% <0.00%> (ø)
cmd/dkg.go 0.00% <0.00%> (ø)
cmd/createcluster.go 50.93% <50.00%> (+0.19%) ⬆️
app/app.go 59.89% <0.00%> (-1.90%) ⬇️
core/qbft/qbft.go 82.57% <0.00%> (+10.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7eea302...2c70498. Read the comment docs.

@xenowits xenowits linked an issue May 23, 2022 that may be closed by this pull request
@xenowits xenowits added the merge when ready Indicates bulldozer bot may merge when all checks pass label May 23, 2022
@obol-bulldozer obol-bulldozer bot merged commit 8e65c3f into main May 23, 2022
@obol-bulldozer obol-bulldozer bot deleted the xenowits/dashes-no-underscores branch May 23, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aligned cluster definition and lock filenames to dashes
2 participants