eth2util/keystore: conform to EIP2335 #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…owits/eip2335-keystores
…owits/eip2335-keystores
Codecov Report
@@ Coverage Diff @@
## main #622 +/- ##
=======================================
Coverage 56.69% 56.69%
=======================================
Files 96 96
Lines 9100 9096 -4
=======================================
- Hits 5159 5157 -2
+ Misses 3197 3196 -1
+ Partials 744 743 -1
Continue to review full report at Codecov.
|
xenowits
commented
May 26, 2022
| }, nil | ||
| } | ||
|
|
||
| // decrypt returns the secret from the encrypted (empty password) keystore. | ||
| func decrypt(store keystore, password string) (*bls_sig.SecretKey, error) { | ||
| // Ugly way to check if the untyped store.Crypto field contains a "scrypt" kdf function. |
There was a problem hiding this comment.
no need to specify cipher when you are decrypting
corverroos
approved these changes
May 26, 2022
corverroos
changed the title
corverroos
reviewed
May 26, 2022
eth2util/keystore/keystore.go
Outdated
| Pubkey: hex.EncodeToString(pubKeyBytes), | ||
| Name: encryptor.Name(), | ||
| Crypto: fields, | ||
| Description: "", |
There was a problem hiding this comment.
add comment why empty maybe? (note you do not need to put empty since that is the default)
xenowits
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor keystore to adhere to EIP2335 spec
category: refactor
ticket: #567