p2p: add deterministic name function using peerID #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #629 +/- ##
==========================================
- Coverage 56.76% 56.74% -0.03%
==========================================
Files 97 97
Lines 9155 9178 +23
==========================================
+ Hits 5197 5208 +11
- Misses 3210 3222 +12
Partials 748 748
Continue to review full report at Codecov.
|
leolara
suggested changes
May 30, 2022
core/consensus/component.go
Outdated
| } | ||
|
|
||
| return nil | ||
| return qbft.Run[core.Duty, [32]byte](ctx, c.def, qt, duty, peerIdx, hash) |
There was a problem hiding this comment.
I don't understand the relation with the task ??
There was a problem hiding this comment.
yeah, these are unrelated. i'm trying to rebase on latest main
app/app.go
Outdated
| if err != nil { | ||
| return err | ||
| // Configure the beacon node api. | ||
| var eth2Cl eth2client.Service |
There was a problem hiding this comment.
I don't understand the relation with the task ??
xenowits
force-pushed
the
xenowits/sapiens-friendly-names
branch
from
d8a25b8
to
4f75ea2
Compare
leolara
approved these changes
May 30, 2022
xenowits
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
p2p.ShortID(pID)withp2p.PeerName(pID)category: feature
ticket: #585