testutil/compose: add unit tests #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corverroos
commented
May 30, 2022
| // a channel on which the received webhooks will be sent. | ||
| func startAlertCollector(ctx context.Context, port int) (chan []byte, error) { | ||
| // a channel on which the received alert titles will be sent. | ||
| func startAlertCollector(ctx context.Context, port int) (chan string, error) { |
There was a problem hiding this comment.
this is going to be refactored away in the next sprint. Move from push Grafana alerts to pull prometheus alerts for the unit tests.
Codecov Report
@@ Coverage Diff @@
## main #630 +/- ##
==========================================
- Coverage 56.76% 55.32% -1.45%
==========================================
Files 96 98 +2
Lines 9130 9430 +300
==========================================
+ Hits 5183 5217 +34
- Misses 3203 3468 +265
- Partials 744 745 +1
Continue to review full report at Codecov.
|
corverroos
commented
May 30, 2022
| //go:generate go test . -run=TestSmoke -integration -v | ||
| var integration = flag.Bool("integration", false, "Enable docker based integration test") | ||
|
|
||
| func TestSmoke(t *testing.T) { |
There was a problem hiding this comment.
These are the unit tests
There was a problem hiding this comment.
Unit tests of smoke tests 🙃
| @@ -1,6 +1,6 @@ | |||
| global: | |||
| scrape_interval: 15s # Set the scrape interval to every 15 seconds. Default is every 1 minute. | |||
| evaluation_interval: 15s # Evaluate rules every 15 seconds. The default is every 1 minute. | |||
| scrape_interval: 5s # Set the scrape interval to every 15 seconds. Default is every 1 minute. | |||
There was a problem hiding this comment.
scrape faster for more responsive alerts
corverroos
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds unit tests for different cluster configurations.
category: test
ticket: #609