p2p: add peer name to networking component contexts #652
Conversation
p2p/peer.go
Outdated
| @@ -27,6 +27,8 @@ import ( | |||
| "github.com/obolnetwork/charon/app/errors" | |||
| ) | |||
|
|
|||
| const PeerCtxKey = "peer" | |||
There was a problem hiding this comment.
is it okay to let other packages depend on p2p just for the context key? other workaround is adding //nolint:revive to all the changes above
There was a problem hiding this comment.
nah, this is not worth it. We use string literals in many places without needing to add nolint...
Codecov Report
@@ Coverage Diff @@
## main #652 +/- ##
==========================================
- Coverage 55.23% 54.56% -0.68%
==========================================
Files 98 98
Lines 9477 9517 +40
==========================================
- Hits 5235 5193 -42
- Misses 3492 3575 +83
+ Partials 750 749 -1
Continue to review full report at Codecov.
|
core/consensus/component.go
Outdated
| @@ -181,6 +181,7 @@ func (c *Component) Propose(ctx context.Context, duty core.Duty, data core.Unsig | |||
| func (c *Component) makeHandler(ctx context.Context) func(s network.Stream) { | |||
| ctx = log.WithTopic(ctx, "qbft") | |||
| return func(s network.Stream) { | |||
| ctx = context.WithValue(ctx, p2p.PeerCtxKey, p2p.PeerName(s.Conn().RemotePeer())) | |||
There was a problem hiding this comment.
you should use the log package for this to work: ctx = log.WithCtx(ctx, z.Str("peer", p2p.PeerName(s.Conn().RemotePeer()))
core/consensus/transport.go
Outdated
| @@ -115,6 +116,7 @@ func (t *transport) Broadcast(ctx context.Context, typ qbft.MsgType, duty core.D | |||
| continue | |||
| } | |||
|
|
|||
| ctx = context.WithValue(ctx, p2p.PeerCtxKey, p2p.PeerName(t.component.tcpNode.ID())) | |||
There was a problem hiding this comment.
this is broadcasting, this ticket is for receiving. p2pSender will handle sending logs.
xenowits
added
the
merge when ready
Add peer names to "receiver" networking components like parsigex.
category: misc
ticket: #645