Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flags: rename bootmanifest to bootlock #660

Merged
merged 1 commit into from
Jun 2, 2022

Conversation

xenowits
Copy link
Contributor

@xenowits xenowits commented Jun 2, 2022

Rename --p2p-bootmanifest flag to --p2p-bootlock.

category: refactor
ticket: #642

@xenowits xenowits linked an issue Jun 2, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jun 2, 2022

Codecov Report

Merging #660 (5637c07) into main (09a53fb) will decrease coverage by 0.02%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main     #660      +/-   ##
==========================================
- Coverage   55.08%   55.05%   -0.03%     
==========================================
  Files          98       98              
  Lines        9517     9517              
==========================================
- Hits         5242     5240       -2     
- Misses       3525     3528       +3     
+ Partials      750      749       -1     
Impacted Files Coverage Δ
p2p/bootnode.go 33.33% <0.00%> (ø)
p2p/config.go 62.50% <ø> (ø)
p2p/relay.go 0.00% <0.00%> (ø)
cmd/run.go 100.00% <100.00%> (ø)
core/qbft/qbft.go 81.25% <0.00%> (-0.65%) ⬇️
core/scheduler/scheduler.go 74.26% <0.00%> (-0.60%) ⬇️
dkg/frostp2p.go 72.55% <0.00%> (ø)
app/app.go 58.77% <0.00%> (+0.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09a53fb...5637c07. Read the comment docs.

@xenowits xenowits added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jun 2, 2022
@obol-bulldozer obol-bulldozer bot merged commit a9ed0eb into main Jun 2, 2022
@obol-bulldozer obol-bulldozer bot deleted the xenowits/p2p-bootmanifest branch June 2, 2022 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

p2p: rename --p2p-bootmanifest flag
2 participants