Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: add clone method to types #706

Merged
merged 1 commit into from
Jun 14, 2022
Merged

core: add clone method to types #706

merged 1 commit into from
Jun 14, 2022

Conversation

corverroos
Copy link
Contributor

Adds the Clone method to SignedData and other core types. This makes explicit that data should be cloned before sharing to ensure immutability.

category: refactor
ticket: #698

@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #706 (5b2e242) into main (0fc5059) will decrease coverage by 0.04%.
The diff coverage is 41.02%.

@@            Coverage Diff             @@
##             main     #706      +/-   ##
==========================================
- Coverage   54.47%   54.42%   -0.05%     
==========================================
  Files         103      103              
  Lines        9913     9971      +58     
==========================================
+ Hits         5400     5427      +27     
- Misses       3727     3760      +33     
+ Partials      786      784       -2     
Impacted Files Coverage Δ
core/types.go 25.00% <0.00%> (-7.26%) ⬇️
core/sigagg/sigagg.go 52.38% <25.00%> (-4.03%) ⬇️
core/signeddata.go 41.42% <42.85%> (-0.07%) ⬇️
core/aggsigdb/memory.go 78.89% <50.00%> (-2.06%) ⬇️
core/validatorapi/validatorapi.go 50.87% <72.72%> (+0.36%) ⬆️
app/app.go 60.50% <0.00%> (+2.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fc5059...5b2e242. Read the comment docs.

@corverroos corverroos added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jun 14, 2022
@obol-bulldozer obol-bulldozer bot merged commit 4e0689b into main Jun 14, 2022
@obol-bulldozer obol-bulldozer bot deleted the corver/cloneparsig branch June 14, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants