core: refactor UnsignedData to interface #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corverroos
commented
Jun 14, 2022
| @@ -287,7 +292,12 @@ func (a Attestation) Clone() (SignedData, error) { | |||
| //nolint:revive // similar method names. | |||
| func (a Attestation) clone() (Attestation, error) { | |||
| var resp Attestation | |||
| return resp, cloneSignedData(a, &resp) | |||
There was a problem hiding this comment.
this super succinct way didn't work, trying to be too smart 😉
Codecov Report
@@ Coverage Diff @@
## main #708 +/- ##
==========================================
- Coverage 54.39% 54.13% -0.26%
==========================================
Files 103 104 +1
Lines 9971 10146 +175
==========================================
+ Hits 5424 5493 +69
- Misses 3761 3845 +84
- Partials 786 808 +22
Continue to review full report at Codecov.
|
corverroos
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors
core.UnsignedDatainto an interface. Follow pattern established viaSignedData.category: refactor
ticket: #698