Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: rename fetch args and update docs #717

Merged
merged 4 commits into from
Jun 15, 2022
Merged

Conversation

corverroos
Copy link
Contributor

Renames FetchArgs to DutyDefinition and update docs.

category: refactor
ticket: #698

@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #717 (c2448bf) into main (62b3975) will increase coverage by 0.09%.
The diff coverage is 74.41%.

@@            Coverage Diff             @@
##             main     #717      +/-   ##
==========================================
+ Coverage   53.97%   54.07%   +0.09%     
==========================================
  Files         104      104              
  Lines       10162    10162              
==========================================
+ Hits         5485     5495      +10     
+ Misses       3871     3867       -4     
+ Partials      806      800       -6     
Impacted Files Coverage Δ
core/dutydefinition.go 0.00% <0.00%> (ø)
core/interfaces.go 0.00% <0.00%> (ø)
core/retry.go 0.00% <0.00%> (ø)
core/tracing.go 15.78% <0.00%> (ø)
core/types.go 20.40% <0.00%> (ø)
core/validatorapi/validatorapi.go 50.87% <80.00%> (ø)
core/scheduler/scheduler.go 73.87% <94.73%> (ø)
app/app.go 59.25% <100.00%> (+1.50%) ⬆️
core/fetcher/fetcher.go 65.21% <100.00%> (ø)
core/scheduler/metrics.go 100.00% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62b3975...c2448bf. Read the comment docs.

@corverroos corverroos added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jun 15, 2022
@obol-bulldozer obol-bulldozer bot merged commit 27022e1 into main Jun 15, 2022
@obol-bulldozer obol-bulldozer bot deleted the corver/coredocs branch June 15, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants