Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change ports #733

Merged
merged 2 commits into from
Jun 21, 2022
Merged

refactor: change ports #733

merged 2 commits into from
Jun 21, 2022

Conversation

xenowits
Copy link
Contributor

Change ports from 16000s to 3600s.

category: refactor
ticket: #732

@xenowits xenowits changed the title change ports refactor: change ports Jun 20, 2022
@codecov
Copy link

codecov bot commented Jun 20, 2022

Codecov Report

Merging #733 (0274b1a) into main (1d6aa77) will increase coverage by 0.46%.
The diff coverage is 90.90%.

@@            Coverage Diff             @@
##             main     #733      +/-   ##
==========================================
+ Coverage   53.45%   53.92%   +0.46%     
==========================================
  Files         106      106              
  Lines       10265    10265              
==========================================
+ Hits         5487     5535      +48     
+ Misses       3961     3914      -47     
+ Partials      817      816       -1     
Impacted Files Coverage Δ
cmd/bootnode.go 40.35% <0.00%> (ø)
cmd/run.go 100.00% <100.00%> (ø)
testutil/compose/lock.go 72.91% <100.00%> (ø)
testutil/compose/run.go 84.21% <100.00%> (ø)
core/qbft/qbft.go 81.97% <0.00%> (+10.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d6aa77...0274b1a. Read the comment docs.

Copy link
Contributor

@OisinKyne OisinKyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CC @eth2devops Apologies, but we are making some more breaking changes.... We're trying to get as many as possible done before we tag a v0.7, and we'll stop pushing breaking changes soon! 😅

@aly-obol
Copy link
Contributor

No worries, updating the ports on my side 👍

Copy link
Contributor

@dB2510 dB2510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@dB2510 dB2510 linked an issue Jun 21, 2022 that may be closed by this pull request
@xenowits xenowits added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jun 21, 2022
@obol-bulldozer obol-bulldozer bot merged commit 5e67194 into main Jun 21, 2022
@obol-bulldozer obol-bulldozer bot deleted the xenowits/port-changes branch June 21, 2022 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: rename ports
4 participants