dkg/sync: add AwaitAllConnected for server #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #743 +/- ##
==========================================
+ Coverage 54.41% 54.58% +0.17%
==========================================
Files 107 107
Lines 10408 10432 +24
==========================================
+ Hits 5663 5694 +31
+ Misses 3921 3916 -5
+ Partials 824 822 -2
Continue to review full report at Codecov.
|
xenowits
reviewed
Jun 23, 2022
| func (*Server) AwaitAllConnected() error { | ||
| func (s *Server) AwaitAllConnected() error { | ||
| var msgs []result | ||
| for len(msgs) < len(s.peers) { |
There was a problem hiding this comment.
not a good practice imo to use value changing variables as loop vars. can do this instead:
for {
if len(msgs) >= len(s.peers) { break }
select {
case <-s.ctx.Done():
return s.ctx.Err()
case msg := <-s.receiveChan:
msgs = append(msgs, msg)
}
}There was a problem hiding this comment.
Inspired from here: https://github.com/ObolNetwork/charon/blob/main/dkg/frostp2p.go#L178
xenowits
reviewed
Jun 23, 2022
xenowits
approved these changes
Jun 23, 2022
Co-authored-by: Abhishek Kumar <43061995+xenowits@users.noreply.github.com>
dB2510
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements AwaitAllConnected method for sync.Server.
category: feature
ticket: #684