dkg/sync: move connected logs to server #771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #771 +/- ##
==========================================
+ Coverage 54.16% 54.56% +0.39%
==========================================
Files 109 109
Lines 10648 10647 -1
==========================================
+ Hits 5768 5810 +42
+ Misses 4020 3976 -44
- Partials 860 861 +1
Continue to review full report at Codecov.
|
xenowits
approved these changes
Jul 7, 2022
corverroos
reviewed
Jul 7, 2022
dkg/sync/server.go
Outdated
| @@ -109,11 +110,12 @@ func (s *Server) isConnected(pID peer.ID) bool { | |||
| } | |||
|
|
|||
| // setConnected sets the shared connected state for the peer. | |||
| func (s *Server) setConnected(pID peer.ID) { | |||
| func (s *Server) setConnected(ctx context.Context, pID peer.ID) { | |||
There was a problem hiding this comment.
another way is to return the length and log with context on the outside
corverroos
approved these changes
Jul 7, 2022
dB2510
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves connected logs to server and removes inbound and outbound logs from client and server.
category: bug
ticket: #762