Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/scheduler: subtract half rtt from sync offset #779

Merged
merged 1 commit into from
Jul 11, 2022

Conversation

corverroos
Copy link
Contributor

@corverroos corverroos commented Jul 8, 2022

Improve sync offset by subtracting the time it takes to send messages over the wire (rtt/2).

category: misc
ticket: #764
feature_flag: beacon_clock_sync

@codecov
Copy link

codecov bot commented Jul 8, 2022

Codecov Report

Merging #779 (999e754) into main (e672e33) will decrease coverage by 0.11%.
The diff coverage is 36.66%.

@@            Coverage Diff             @@
##             main     #779      +/-   ##
==========================================
- Coverage   54.47%   54.35%   -0.12%     
==========================================
  Files         109      109              
  Lines       10667    10696      +29     
==========================================
+ Hits         5811     5814       +3     
- Misses       3992     4014      +22     
- Partials      864      868       +4     
Impacted Files Coverage Δ
core/scheduler/metrics.go 100.00% <ø> (ø)
core/scheduler/clocksync.go 62.33% <29.62%> (-17.67%) ⬇️
core/scheduler/scheduler.go 71.69% <100.00%> (+0.15%) ⬆️
core/qbft/qbft.go 80.47% <0.00%> (-1.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e672e33...999e754. Read the comment docs.

@corverroos corverroos added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jul 11, 2022
@obol-bulldozer obol-bulldozer bot merged commit 12b11de into main Jul 11, 2022
@obol-bulldozer obol-bulldozer bot deleted the corver/schedrtt branch July 11, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants