-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core/deadline: ignore deadlined duties #819
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #819 +/- ##
==========================================
+ Coverage 54.58% 54.73% +0.14%
==========================================
Files 111 111
Lines 11347 11384 +37
==========================================
+ Hits 6194 6231 +37
+ Misses 4251 4249 -2
- Partials 902 904 +2
Continue to review full report at Codecov.
|
dB2510
changed the title
core/tracker: ignore deadlined duties
core/dealine: ignore deadlined duties
Jul 20, 2022
dB2510
changed the title
core/dealine: ignore deadlined duties
core/deadline: ignore deadlined duties
Jul 20, 2022
dB2510
reviewed
Jul 20, 2022
dB2510
reviewed
Jul 20, 2022
corverroos
reviewed
Jul 20, 2022
corverroos
added
the
do not merge
Indicate to bulldozer bot that this PR should not be merged
label
Jul 20, 2022
xenowits
force-pushed
the
xenowits/ignore-deadlined-duties
branch
from
July 21, 2022 06:37
655fb0d
to
b545420
Compare
xenowits
commented
Jul 21, 2022
xenowits
force-pushed
the
xenowits/ignore-deadlined-duties
branch
from
July 21, 2022 07:58
9598de2
to
86cef87
Compare
xenowits
commented
Jul 21, 2022
corverroos
approved these changes
Jul 21, 2022
corverroos
removed
the
do not merge
Indicate to bulldozer bot that this PR should not be merged
label
Jul 21, 2022
xenowits
added
the
merge when ready
Indicates bulldozer bot may merge when all checks pass
label
Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deadliner
to ignore deadlined duties.Add(duty)
to return true if a duty is added successfully.category: refactor
ticket: #814