Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/deadline: ignore deadlined duties #819

Merged
merged 4 commits into from
Jul 21, 2022

Conversation

xenowits
Copy link
Contributor

@xenowits xenowits commented Jul 20, 2022

  • Modify Deadliner to ignore deadlined duties.
  • Modify Add(duty) to return true if a duty is added successfully.
  • Fix deadline tests.

category: refactor
ticket: #814

@codecov
Copy link

codecov bot commented Jul 20, 2022

Codecov Report

Merging #819 (25bb192) into main (fa8712e) will increase coverage by 0.14%.
The diff coverage is 85.07%.

@@            Coverage Diff             @@
##             main     #819      +/-   ##
==========================================
+ Coverage   54.58%   54.73%   +0.14%     
==========================================
  Files         111      111              
  Lines       11347    11384      +37     
==========================================
+ Hits         6194     6231      +37     
+ Misses       4251     4249       -2     
- Partials      902      904       +2     
Impacted Files Coverage Δ
core/tracker/tracker.go 74.37% <0.00%> (-1.73%) ⬇️
core/deadline.go 64.86% <89.06%> (-3.14%) ⬇️
core/qbft/qbft.go 81.11% <0.00%> (-0.86%) ⬇️
dkg/transport.go 66.66% <0.00%> (+12.96%) ⬆️
core/types.go 37.61% <0.00%> (+13.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa8712e...25bb192. Read the comment docs.

@dB2510 dB2510 changed the title core/tracker: ignore deadlined duties core/dealine: ignore deadlined duties Jul 20, 2022
@dB2510 dB2510 changed the title core/dealine: ignore deadlined duties core/deadline: ignore deadlined duties Jul 20, 2022
core/deadline.go Outdated Show resolved Hide resolved
core/deadline.go Outdated Show resolved Hide resolved
core/deadline.go Outdated Show resolved Hide resolved
core/deadline.go Outdated Show resolved Hide resolved
core/deadline_test.go Outdated Show resolved Hide resolved
core/deadline.go Outdated Show resolved Hide resolved
core/deadline.go Outdated Show resolved Hide resolved
@corverroos corverroos added the do not merge Indicate to bulldozer bot that this PR should not be merged label Jul 20, 2022
@xenowits xenowits force-pushed the xenowits/ignore-deadlined-duties branch from 655fb0d to b545420 Compare July 21, 2022 06:37
@xenowits xenowits force-pushed the xenowits/ignore-deadlined-duties branch from 9598de2 to 86cef87 Compare July 21, 2022 07:58
core/deadline.go Outdated Show resolved Hide resolved
core/deadline_test.go Outdated Show resolved Hide resolved
core/deadline_test.go Outdated Show resolved Hide resolved
core/tracker/tracker.go Outdated Show resolved Hide resolved
@corverroos corverroos removed the do not merge Indicate to bulldozer bot that this PR should not be merged label Jul 21, 2022
@xenowits xenowits added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jul 21, 2022
@obol-bulldozer obol-bulldozer bot merged commit f9faed9 into main Jul 21, 2022
@obol-bulldozer obol-bulldozer bot deleted the xenowits/ignore-deadlined-duties branch July 21, 2022 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants