Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: add builder registration duty type #852

Conversation

ciaranmcveigh5
Copy link
Contributor

@ciaranmcveigh5 ciaranmcveigh5 commented Jul 26, 2022

Jim has merged in the builder registration PR attestantio/go-eth2-client#19 so we are unblocked on that flow now

  • Add DutyBuilderRegistration
  • Update tests to include the registration duty

category: feature
ticket: #849

@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #852 (cb318eb) into main (f801a6d) will decrease coverage by 0.03%.
The diff coverage is 58.33%.

@@            Coverage Diff             @@
##             main     #852      +/-   ##
==========================================
- Coverage   55.25%   55.21%   -0.04%     
==========================================
  Files         112      112              
  Lines       11724    11730       +6     
==========================================
- Hits         6478     6477       -1     
- Misses       4309     4316       +7     
  Partials      937      937              
Impacted Files Coverage Δ
core/types.go 36.52% <58.33%> (-1.10%) ⬇️
core/dutydb/memory.go 70.63% <0.00%> (-1.28%) ⬇️
app/app.go 56.60% <0.00%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f801a6d...cb318eb. Read the comment docs.

@corverroos
Copy link
Contributor

🚀

@ciaranmcveigh5 ciaranmcveigh5 added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jul 26, 2022
@obol-bulldozer obol-bulldozer bot merged commit f3d8f46 into ObolNetwork:main Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants