Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: refactor v1.2.0 to hex #854

Merged
merged 2 commits into from
Jul 27, 2022
Merged

cluster: refactor v1.2.0 to hex #854

merged 2 commits into from
Jul 27, 2022

Conversation

corverroos
Copy link
Contributor

@corverroos corverroos commented Jul 26, 2022

Refactors v1.2.0 to hex instead of base58 since that is standard ETH format for bytes.

category: refactor
ticket: #848

@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #854 (a240cfb) into main (f3d8f46) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #854      +/-   ##
==========================================
- Coverage   54.79%   54.79%   -0.01%     
==========================================
  Files         113      113              
  Lines       12014    11996      -18     
==========================================
- Hits         6583     6573      -10     
+ Misses       4480     4470      -10     
- Partials      951      953       +2     
Impacted Files Coverage Δ
cluster/definition.go 56.04% <ø> (ø)
cluster/helpers.go 72.00% <ø> (+7.48%) ⬆️
cluster/lock.go 56.48% <ø> (ø)
cluster/version.go 100.00% <ø> (ø)
cluster/distvalidator.go 71.60% <50.00%> (ø)
app/app.go 54.86% <0.00%> (-1.75%) ⬇️
core/dutydb/memory.go 70.63% <0.00%> (-1.28%) ⬇️
p2p/p2p.go 23.30% <0.00%> (-0.98%) ⬇️
dkg/transport.go 66.66% <0.00%> (+12.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3d8f46...a240cfb. Read the comment docs.

@corverroos corverroos added Let's discuss Discussion for general feedback and positive criticism :) and removed Let's discuss Discussion for general feedback and positive criticism :) labels Jul 26, 2022
@corverroos corverroos added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jul 27, 2022
@obol-bulldozer obol-bulldozer bot merged commit 1adae1b into main Jul 27, 2022
@obol-bulldozer obol-bulldozer bot deleted the corver/clusterhex branch July 27, 2022 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants