app: add simnet builder proposer unit test #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #858 +/- ##
==========================================
- Coverage 55.33% 55.24% -0.10%
==========================================
Files 113 113
Lines 12077 12089 +12
==========================================
- Hits 6683 6678 -5
- Misses 4437 4447 +10
- Partials 957 964 +7
Continue to review full report at Codecov.
|
xenowits
reviewed
Jul 26, 2022
app/app.go
Outdated
| @@ -631,6 +631,13 @@ func callValidatorMock(ctx context.Context, duty core.Duty, cl eth2client.Servic | |||
| } else { | |||
| log.Info(ctx, "Mock block proposal submitted to validatorapi", z.I64("slot", duty.Slot)) | |||
| } | |||
| case core.DutyBuilderProposer: | |||
| err := validatormock.ProposeBlindedBlock(ctx, cl.(*eth2http.Service), signer, eth2p0.Slot(duty.Slot), addr, pubshares...) | |||
There was a problem hiding this comment.
can assign eth2Svc := cl.(*eth2http.Service) since the typecast happens in all cases
xenowits
approved these changes
Jul 26, 2022
corverroos
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add unit test for builder proposer and fix few integration issues.
category: test
ticket: #809