Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testutil: random function for builder registration needed for vapi #870

Conversation

ciaranmcveigh5
Copy link
Contributor

  • Add random function for incoming vapi PR

category: feature
ticket: #849

@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

Merging #870 (668d139) into main (827d675) will decrease coverage by 0.32%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #870      +/-   ##
==========================================
- Coverage   54.39%   54.06%   -0.33%     
==========================================
  Files         114      114              
  Lines       12211    12213       +2     
==========================================
- Hits         6642     6603      -39     
- Misses       4603     4646      +43     
+ Partials      966      964       -2     
Impacted Files Coverage Δ
core/qbft/qbft.go 71.67% <0.00%> (-9.45%) ⬇️
p2p/discovery.go 47.88% <0.00%> (-1.39%) ⬇️
core/dutydb/memory.go 70.63% <0.00%> (-1.28%) ⬇️
p2p/p2p.go 24.27% <0.00%> (+0.97%) ⬆️
dkg/transport.go 66.66% <0.00%> (+12.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 827d675...668d139. Read the comment docs.

t.Helper()

return &eth2v1.ValidatorRegistration{
FeeRecipient: bellatrix.ExecutionAddress{},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can omit zero values, since they are automatically populated.

@ciaranmcveigh5 ciaranmcveigh5 added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jul 28, 2022
@obol-bulldozer obol-bulldozer bot merged commit fcbf945 into ObolNetwork:main Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants