core/bcast: implementation for builder registration #881
Conversation
| aggData := core.VersionedSignedValidatorRegistration{VersionedSignedValidatorRegistration: registration} | ||
|
|
||
| mock.SubmitValidatorRegistrationsFunc = func(ctx context.Context, registrations []*eth2api.VersionedSignedValidatorRegistration) error { | ||
| require.Equal(t, aggData.VersionedSignedValidatorRegistration, *registrations[0]) |
There was a problem hiding this comment.
this bcast is submitting 1 validator registration so we compare registrations[0]
should we be constructing an array with mutliple registrations and checking that array is equal to the registrations (array) in the mocksSubmitValidatorRegistrationsFunc
There was a problem hiding this comment.
can do that or just check the length is 1
core/bcast/bcast.go
Outdated
| case core.DutyBuilderRegistration: | ||
| registration, ok := aggData.(core.VersionedSignedValidatorRegistration) | ||
| if !ok { | ||
| return errors.New("invalid exit") |
| aggData := core.VersionedSignedValidatorRegistration{VersionedSignedValidatorRegistration: registration} | ||
|
|
||
| mock.SubmitValidatorRegistrationsFunc = func(ctx context.Context, registrations []*eth2api.VersionedSignedValidatorRegistration) error { | ||
| require.Equal(t, aggData.VersionedSignedValidatorRegistration, *registrations[0]) |
There was a problem hiding this comment.
can do that or just check the length is 1
ciaranmcveigh5
force-pushed
the
ciaran/bcast-builder-registration
branch
from
1507e63
to
13df4a8
Compare
Codecov Report
@@ Coverage Diff @@
## main #881 +/- ##
==========================================
- Coverage 54.47% 54.45% -0.03%
==========================================
Files 114 114
Lines 12324 12336 +12
==========================================
+ Hits 6714 6718 +4
- Misses 4637 4643 +6
- Partials 973 975 +2
Continue to review full report at Codecov.
|
ciaranmcveigh5
added
the
merge when ready
category: feature
ticket: #849