Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: write expanded form of enr in charon enr #913

Merged
merged 6 commits into from
Aug 4, 2022

Conversation

xenowits
Copy link
Contributor

@xenowits xenowits commented Aug 4, 2022

  • charon create enr now errors when charon-enr-private-key already exists.
  • charon enr now also outputssecp256k1 pubkey, signature and seq in addition to the enr when the --verbose flag is provided.

category: refactor
ticket: #893

cmd/enr.go Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #913 (17a79e4) into main (a144a15) will decrease coverage by 0.27%.
The diff coverage is 5.12%.

@@            Coverage Diff             @@
##             main     #913      +/-   ##
==========================================
- Coverage   54.82%   54.55%   -0.28%     
==========================================
  Files         114      115       +1     
  Lines       12342    12497     +155     
==========================================
+ Hits         6767     6818      +51     
- Misses       4599     4678      +79     
- Partials      976     1001      +25     
Impacted Files Coverage Δ
cmd/enr.go 6.34% <2.85%> (-5.42%) ⬇️
cmd/createenr.go 82.35% <25.00%> (-4.89%) ⬇️
eth2util/signing/signing.go 38.52% <0.00%> (ø)
core/dutydb/memory.go 71.91% <0.00%> (+1.27%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dB2510 dB2510 changed the title write expanded form of enr in charon enr cmd: write expanded form of enr in charon enr Aug 4, 2022
@xenowits xenowits changed the title cmd: write expanded form of enr in charon enr cmd/enr: write expanded form of enr in charon enr Aug 4, 2022
@xenowits xenowits changed the title cmd/enr: write expanded form of enr in charon enr cmd: write expanded form of enr in charon enr Aug 4, 2022
cmd/createenr.go Outdated Show resolved Hide resolved
cmd/enr.go Outdated Show resolved Hide resolved
cmd/enr.go Outdated Show resolved Hide resolved
@xenowits xenowits added the merge when ready Indicates bulldozer bot may merge when all checks pass label Aug 4, 2022
@obol-bulldozer obol-bulldozer bot merged commit 4453fee into main Aug 4, 2022
@obol-bulldozer obol-bulldozer bot deleted the xenowits/charon-create-enr branch August 4, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants