core/validatorapi: add verification functions to validatorapi #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #953 +/- ##
==========================================
+ Coverage 54.20% 54.26% +0.06%
==========================================
Files 116 116
Lines 12675 12681 +6
==========================================
+ Hits 6870 6881 +11
+ Misses 4808 4800 -8
- Partials 997 1000 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
corverroos
reviewed
Aug 10, 2022
eth2util/signing/signing.go
Outdated
| // To avoid pointer vs non-pointer issues, always get value if pointer is provided. | ||
| if reflect.TypeOf(eth2SignedType).Kind() == reflect.Pointer { | ||
| eth2SignedType = reflect.ValueOf(eth2SignedType).Elem().Interface() | ||
| func VerifyAttestation(ctx context.Context, eth2Cl Eth2Provider, pubkey *bls_sig.PublicKey, att eth2p0.Attestation) error { |
There was a problem hiding this comment.
I think all these eth2 types should be pointers, since that is how goeth2 users them, always as pointers.
corverroos
approved these changes
Aug 10, 2022
dB2510
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds verification functions for each duty in eth2util/signing and use them in validatorapi.
category: refactor
ticket: #217