core/tracker: improve failed duty message #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #972 +/- ##
==========================================
+ Coverage 54.21% 54.36% +0.15%
==========================================
Files 116 116
Lines 12846 12883 +37
==========================================
+ Hits 6964 7004 +40
+ Misses 4860 4859 -1
+ Partials 1022 1020 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
xenowits
changed the title
corverroos
reviewed
Aug 15, 2022
xenowits
force-pushed
the
xenowits/improve-failed-duty-message
branch
from
b2b6cf4
to
26d083e
Compare
xenowits
force-pushed
the
xenowits/improve-failed-duty-message
branch
from
26d083e
to
9f325db
Compare
Added tests |
corverroos
approved these changes
Aug 16, 2022
core/tracker/tracker.go
Outdated
| } | ||
| } | ||
| case consensus: | ||
| msg = "consensus algorithm didn't complete" |
There was a problem hiding this comment.
maybe make these constants, so comparison and tests and updates are trivial.
There was a problem hiding this comment.
agreed, great idea
xenowits
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve failed duty message.
category: refactor
ticket: #866