core/consensus: fix memory leak #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
profile: |
Codecov Report
@@ Coverage Diff @@
## main #977 +/- ##
==========================================
- Coverage 54.14% 54.11% -0.03%
==========================================
Files 116 116
Lines 12750 12768 +18
==========================================
+ Hits 6903 6910 +7
- Misses 4831 4841 +10
- Partials 1016 1017 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
how is this memory profile generated? |
xenowits
approved these changes
Aug 15, 2022
corverroos
added
the
merge when ready
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes leaked context in consensus stream handler due to variable shadowing.
Also trim receive channel on duty deadline.
category: bug
ticket: #974