Catch exceptions

ObsidianMC · Mar 3, 2024 · 9ff760f · 9ff760f
1 parent d3a2867
commit 9ff760f
Showing 1 changed file with 11 additions and 5 deletions.
diff --git a/Obsidian/Server.cs b/Obsidian/Server.cs
@@ -394,13 +394,19 @@ async Task ExecuteAsync(Client client)
             {
                 // Ignore.
             }
+            catch (Exception exception)
+            {
+                _logger.LogError("Unexpected exception from client {Identifier}: {Message}", client.id, exception.Message);
+            }
+            finally
+            {
+                _clients.TryRemove(client);
 
-            _clients.TryRemove(client);
-
-            if (client.Player is not null)
-                _ = OnlinePlayers.TryRemove(client.Player.Uuid, out _);
+                if (client.Player is not null)
+                    _ = OnlinePlayers.TryRemove(client.Player.Uuid, out _);
 
-            client.Dispose();
+                client.Dispose();
+            }
         }
     }