Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings for entities #358

Merged
merged 4 commits into from
May 30, 2023
Merged

Fix warnings for entities #358

merged 4 commits into from
May 30, 2023

Conversation

Seb-stian
Copy link
Member

Mostly fixing nullable reference warnings

Jonpro03
Jonpro03 previously approved these changes May 29, 2023
View reviewed changes
Copy link
Member

@Jonpro03 Jonpro03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this.

@Seb-stian
Copy link
Member Author

Seb-stian commented May 29, 2023 •
edited
Loading

Seems that some conflicts popped up. Working on a fix now

Edit: done

@github-actions github-actions bot added api Relates to Obsidian.API commands Relates to Obsidian.Commands labels May 29, 2023
@Naamloos
Copy link
Member

opsies conflicts

@Seb-stian
Copy link
Member Author

Not again 😭

@Tides Tides merged commit 802109c into master May 30, 2023
2 checks passed
@Tides Tides deleted the fix-entity-warnings branch May 30, 2023 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tides Tides Tides left review comments

@Jonpro03 Jonpro03 Jonpro03 left review comments

Assignees
No one assigned
Labels
api Relates to Obsidian.API commands Relates to Obsidian.Commands
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Seb-stian @Naamloos @Jonpro03 @Tides