Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace method=getXXX in the url query paramters with updated end points #27

Open
kan-fu opened this issue Feb 29, 2024 · 2 comments
Open
Labels
enhancement New feature or request

Comments

@kan-fu
Copy link
Collaborator

kan-fu commented Feb 29, 2024

There are two ways to get a location tree

  1. Use /location/tree.
  2. Use /location?method=getTree.

The OpenAPI page uses the first style, while the client library uses the second one. They are handled equally in the backend, but it would be better to update the client library to follow the first style.

There are also other methods that need update like _OncRealTime.py, _OncArchive.py and _OncDelivery.py.

@kan-fu kan-fu added the enhancement New feature or request label Feb 29, 2024
@Jacob-Stevens-Haas
Copy link
Collaborator

Just to clarify, you don't mean removing methods like ONC.getLocations(), but to get them to call the Oceans 3 API differently?

@kan-fu kan-fu changed the title Remove getXXX method Replace getXXX method in the url query paramters with updated end points Mar 11, 2024
@kan-fu kan-fu changed the title Replace getXXX method in the url query paramters with updated end points Replace method=getXXX in the url query paramters with updated end points Mar 11, 2024
@kan-fu
Copy link
Collaborator Author

kan-fu commented Mar 11, 2024

Just to clarify, you don't mean removing methods like ONC.getLocations(), but to get them to call the Oceans 3 API differently?

You are right. Now I look at the title, it really seems that I want to delete the public methods 😅. I have updated the title to make it more clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

2 participants