Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make the Stommel test case work #80

Closed
erikvansebille opened this issue Jun 14, 2016 · 1 comment
Closed

make the Stommel test case work #80

erikvansebille opened this issue Jun 14, 2016 · 1 comment
Assignees
@erikvansebille

Comments

@erikvansebille
Copy link
Member

The Stommel test case (test_stommel.py) is currently xfail and should be fixed.
@erikvansebille erikvansebille self-assigned this Jun 14, 2016
erikvansebille added a commit that referenced this issue Jun 21, 2016
@erikvansebille
Updated implementation of the Stommel test case
ef31108 
A (non-working) update to the Stommel test case, as per #80
Now using a solution to the Stommel gyre at
https://books.google.co.uk/books?id=OYAkMs85848C&pg=PA417&lpg=PA417&dq=a
nalytical+solution+to+stommel+gyre&source=bl&ots=xTTPK83bXj&sig=Qbwpv1ec
s40qdYNuJfWGS8t5tI4&hl=en&sa=X&ved=0ahUKEwjEu7y4uLnNAhWLDBoKHYnvBRkQ6AEI
ITAB#v=onepage&q=analytical%20solution%20to%20stommel%20gyre&f=false
@erikvansebille erikvansebille removed the bug label Aug 4, 2016
@erikvansebille erikvansebille mentioned this issue Aug 4, 2016
Closed
@erikvansebille erikvansebille mentioned this issue Aug 15, 2016
Merged
erikvansebille added a commit that referenced this issue Sep 5, 2016
@erikvansebille
Fixed RK45 in #80 by using __dt as argument to loop
f640e0b
@erikvansebille
Copy link
Member Author

Fixed in PR #105

mlange05 pushed a commit that referenced this issue Sep 13, 2016
@erikvansebille
Fixed RK45 in #80 by using __dt as argument to loop
5370b29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erikvansebille erikvansebille

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@erikvansebille