Options for alternative spatial interpolation methods #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a few lines fields alternative interpolation method arguments to be passed to SciPy’s `RegularGridInterpolator` interpolator method. At present, fields’ `self.interp_method` defaults to linear, and must be set manually by the user for each field. @mlange05 or @erikvansebille can you take a quick look at this? `Field.interpolator2D` is cached method, and so I’m concerned that my additions may not actually do anything if the field.interp_method is changed after initialisation (which it always is at present).
|
Yes, this looks nice and it should not interfere with caching at all - the |
|
I like it too, @Jacketless! Also, we need to make very clear that this
In JIT, we've written our own linear interpolation method, and while eventually we want more options there too, that's not really a priority for the v0.9 we're working towards at the moment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a few lines fields alternative interpolation method arguments to
be passed to SciPy’s
RegularGridInterpolatorinterpolator method.At present, fields’
self.interp_methoddefaults to linear, and mustbe set manually by the user for each field.
@mlange05 or @erikvansebille can you take a quick look at this?
Field.interpolator2Dis cached method, and so I’m concerned that myadditions may not actually do anything if the field.interp_method is
changed after initialisation (which it always is at present).