Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation info as metadata #1433

Merged
merged 8 commits into from Oct 2, 2023
Merged

Conversation

erikvansebille
Copy link
Member

@erikvansebille erikvansebille commented Sep 26, 2023

This PR changes the way that Compilation Information is presented. It is now only displayed as a logging message if delete_cfiles=False; and is always stored as a metadata attribute in the zarr output

Furthermore, this PR also cleans up the codeconverter (old stray code that was left after #1423)

Todo

  • Always show progress bar, even for short runs, as this gives useful feedback to users and also gives a more accurate time estimate (and remove verbose_progress=True option?)

@erikvansebille erikvansebille mentioned this pull request Sep 28, 2023
10 tasks
@erikvansebille erikvansebille merged commit ee601b0 into v3.0 Oct 2, 2023
12 checks passed
@erikvansebille erikvansebille deleted the compilationinfo_as_metadata branch October 2, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant