Compilation error message fix for local variable name that is also FieldSet constant #1552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… same name as a FieldSet constant This fixes #1512
VascoSch92
reviewed
Apr 30, 2024
| @@ -186,6 +187,31 @@ def kernel_pnum(particle, fieldset, time): | |||
| assert error_thrown | |||
|
|
|||
|
|
|||
| def test_varname_as_fieldname(): | |||
There was a problem hiding this comment.
You can use pytest.raises(Exception). It is a much easier way to test that the code raise exception.
Thanks for the tip, @VascoSch92!
VascoSch92
reviewed
Apr 30, 2024
Co-authored-by: Vasco Schiavo <115561717+VascoSch92@users.noreply.github.com>
Following suggestion by @VascoSch92
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the compilation error message when a local Kernel variable has same name as a FieldSet constant
This fixes #1512